Tacsipacsi
Beigetreten 19. Juni 2012
Letzter Kommentar: vor 5 Jahren von PerfektesChaos in Abschnitt Your recent changes at LuaModuleDoc
Your recent changes at LuaModuleDoc
BearbeitenIt is not desired in this Wiki to intervene into complex programming out of the blue affecting productive versions.
- It is common practice to announce a suggestion first, asking whether this would be appreciated.
- In this particular case there is a full model at BETA. Which goes for many of tricky software. Before changing the productive version in real Wikipedia, it is obligatory to perform thoroughly tests and get agreement of meaningful and non-disruptive outcome.
- Anyway, you have failed to provide the mandatory documentation for Vorlage:LuaModuleDoc/Navigation/styles.css which is neither the appropriate page name for this purpose nor the behaviour is sufficiently explained to the rest of the world other than you.
--PerfektesChaos 18:28, 22. Jun. 2019 (CEST)
- @PerfektesChaos: I don’t think this modification would have required discussion: on the one hand, it introduced a technology that’s already used in such “rare” templates like Taxobox and IPA; on the other hand, it contained a bug fix (which I explained in my edit summary): the previous version was unreadable on narrow screens/with narrow browser window. The change hasn’t affected the layout of the template on wider screens.
- What documentation does a CSS page need? It’s not a Lua module (therefore it’s not equivalent with the module you linked from beta), it just contains CSS rules, the same as what was in the template code previously, but in a more readable manner. See the Taxobox stylesheet I linked above: it doesn’t have more documentation. And could you please tell me what the appropriate page name is? Dozens of pages follow this naming scheme on the German Wikipedia (while only a handful have different ones), so I’d be surprized if another name would be more appropriate. —Tacsipacsi (Diskussion) 21:11, 22. Jun. 2019 (CEST)
- It does need previous consultation:
- You are separating inline styles from a position where its usage and consequence is obvious to some unknown place where the definition is not obvious any longer. This is not permitted on this Wiki.
- Basically there is no effect on @media type nor
:
pseudo class. Therefore the moving of CSS does not has any effect, even if moved without modification. This is hard and cumbersome to check what you actually did. - It does not matter that what you are doing is practised on any other Wiki, like Hungarian or English Wikipedia. This is German Wikipedia, and you are to obey the rules and customs of this project here, not of any other.
- What you were doing already caused a block or ban here.
- The following sequence is to be accomplished:
- Make a suggestion, what you want to get improved, and show reasons and benefits.
- Most complex productive programming is already in a sandbox solution present via WP:BETA, or can be copied if not yet present.
- Demonstrate a solution, if clarified whether desired, on BETA.
- Create all necessary documentation and description.
- Ask for consensus.
- After approval and exhaustive testing the new ideas may be copied into the real project.
- On naming structure: The subpaging
/Navigation
is invalid. If ever, there will be one and only one overall Vorlage:LuaModuleDoc/styles.css for everything concerningLuaModuleDoc
package issues, not split into many subpages at unexpected locations. - On documentation: Before a project class has been introduced, its purpose, intended appearance on desktop and perhaps mobile and rules for applying is to be described exhaustively on the connected documentation page.
- Without documentation page nobody knows which class ID is intended for which purpose.
- Without documentation page no maintenance is possible for local folks, even more if someone from some outer place rushes in, changes something and vanishes again. It is even not allowed to locals to introduce new classes without description of purpose and future support.
- The documentation page is also supposed to show expected effect, if possible, and comparing test cases with current TemplateStyles applied to elements against desired outcome.
- The class pattern in this particular case, if ever, would be
.LuaModuleDoc-
whatever anybody else on this globe might do with lowercase letters. - All class patterns are subject of central project wide documentation before first usage in any page.
- The fundamental error has been to act first without any question. It would have been sufficient to read Help:TemplateStyles first, which would have explained how to proceed, and to tell your proposal on any related talk page before modification.
- --PerfektesChaos 21:45, 22. Jun. 2019 (CEST)
- It does need previous consultation: